clang-plugin: Enable RecursiveASTVisitor approach by default.

tools/clang/plugins/ChromeClassTester.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_CLANG_PLUGINS_CHROMECLASSTESTER_H_
 #define TOOLS_CLANG_PLUGINS_CHROMECLASSTESTER_H_
 
 #include <set>
 #include <vector>
 
 #include "Options.h"
 #include "clang/AST/ASTConsumer.h"
 #include "clang/AST/TypeLoc.h"
 #include "clang/Frontend/CompilerInstance.h"
 
 // A class on top of ASTConsumer that forwards classes defined in Chromium
 // headers to subclasses which implement CheckChromeClass().
+// TODO(vmpstr): Remove the clang::ASTConsumer base and fold this class into

[dcheng, 2016/02/16 23:03:50]

Can we just remove the base class now?

[vmpstr, 2016/02/16 23:13:27]

Yep! Done.

+// FindBadConstructsConsumer.
 class ChromeClassTester : public clang::ASTConsumer {
  public:
   ChromeClassTester(clang::CompilerInstance& instance,
                     const chrome_checker::Options& options);
   virtual ~ChromeClassTester();
 
   // clang::ASTConsumer:
   virtual void HandleTagDeclDefinition(clang::TagDecl* tag);
   virtual bool HandleTopLevelDecl(clang::DeclGroupRef group_ref);
 
@@ skipping 67 matching lines @@
   std::set<std::string> banned_directories_;
 
   // List of types that we don't check.
   std::set<std::string> ignored_record_names_;
 
   // List of decls to check once the current top-level decl is parsed.
   std::vector<clang::TagDecl*> pending_class_decls_;
 };
 
 #endif  // TOOLS_CLANG_PLUGINS_CHROMECLASSTESTER_H_