Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 1703683003: The key event should be stopped propagation when it's been processed as an accelerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CQ green. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_interactive_uitest.cc
diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc
index 32866e1bf72f1bf9192dacdb73e866ff4ce958ea..61431a6a3b9dc5f475f2a12b13b19fd41a36079b 100644
--- a/ui/views/widget/widget_interactive_uitest.cc
+++ b/ui/views/widget/widget_interactive_uitest.cc
@@ -1644,5 +1644,33 @@ TEST_F(WidgetInputMethodInteractiveTest, TextField) {
widget->CloseNow();
}
+// Test input method should not work for accelerator.
+TEST_F(WidgetInputMethodInteractiveTest, AcceleratorInTextfield) {
+ Widget* widget = CreateWidget();
+ Textfield* textfield = new Textfield;
+ widget->GetRootView()->AddChildView(textfield);
+ ShowSync(widget);
+ textfield->SetTextInputType(ui::TEXT_INPUT_TYPE_TEXT);
+ textfield->RequestFocus();
+
+ ui::KeyEvent key_event(ui::ET_KEY_PRESSED,
+ ui::VKEY_F, ui::EF_ALT_DOWN);
+ ui::Accelerator accelerator(key_event);
+ widget->GetFocusManager()->RegisterAccelerator(
+ accelerator, ui::AcceleratorManager::kNormalPriority,
+ textfield);
+
+ widget->OnKeyEvent(&key_event);
+ EXPECT_TRUE(key_event.stopped_propagation());
+
+ widget->GetFocusManager()->UnregisterAccelerators(textfield);
+
+ ui::KeyEvent key_event2(key_event);
+ widget->OnKeyEvent(&key_event2);
+ EXPECT_FALSE(key_event2.stopped_propagation());
+
+ widget->CloseNow();
+}
+
} // namespace test
} // namespace views
« no previous file with comments | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698