ui/views/widget/widget.cc - Issue 1703683003: The key event should be stopped propagation when it's been processed as an accelerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget.cc

Issue 1703683003: The key event should be stopped propagation when it's been processed as an accelerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CQ green. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/widget.cc

diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc

index 88a68dad587ba9335b3ceeff9c14a641e6b1f2f5..84fa83ec405f0798088bfc086b551bf89640e846 100644

--- a/ui/views/widget/widget.cc

+++ b/ui/views/widget/widget.cc

@@ -1162,6 +1162,10 @@ int Widget::GetNonClientComponent(const gfx::Point& point) {

void Widget::OnKeyEvent(ui::KeyEvent* event) {

SendEventToProcessor(event);

+ if (!event->handled() && GetFocusManager() &&

+ !GetFocusManager()->OnKeyEvent(*event)) {

+ event->StopPropagation();

+ }

}

// TODO(tdanderson): We should not be calling the OnMouse*() functions on

« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/views/widget/widget_interactive_uitest.cc » ('j') | no next file with comments »