Port Skia recipe to normal Python scripts, move to Skia repo

Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Committed: https://skia.googlesource.com/skia/+/d9fa758292462c4200231f49286aa97750f5e689

[borenet, 2016-02-16 20:41:19]

Description was changed from

==========
Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
==========

to

==========
Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-02-18 13:56:20]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 13:56:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703663002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703663002/70001

[commit-bot: I haz the power, 2016-02-18 13:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 13:58:06]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[borenet, 2016-02-18 14:01:10]

borenet@google.com changed reviewers:
+ rmistry@google.com

[borenet, 2016-02-18 14:01:11]

Publishing for preliminary review.

I'm thinking about changing the directory from skiabot/ to testing/ or
something.

[rmistry, 2016-02-18 15:29:21]

lgtm module nits

https://codereview.chromium.org/1703663002/diff/90001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1703663002/diff/90001/PRESUBMIT.py#newcode88
PRESUBMIT.py:88: 'W0105',  # String statement has no effect.
Out of curiosity, where did you run into this?

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/common.py
File infra/bots/common.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/common.py#ne...
infra/bots/common.py:9: import json
Not used? I wonder why the linter did not catch this.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
File infra/bots/compile_skia.isolate (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.isolate:1: {
[For later] Putting isolate files and the top level scripts under bots/ is
probably ok for now. If it gets to be a lot we might want to look into creating
subdirs.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia.py
File infra/bots/compile_skia.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.py:10: import os
unused

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.py:11: import subprocess
unused

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/andro...
File infra/bots/flavor/android_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/andro...
infra/bots/flavor/android_flavor.py:10: import copy
unused

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
File infra/bots/flavor/coverage_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
infra/bots/flavor/coverage_flavor.py:9: import datetime
unused

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
infra/bots/flavor/coverage_flavor.py:12: import ssh_devices
unused

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/ios_f...
File infra/bots/flavor/ios_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/ios_f...
infra/bots/flavor/ios_flavor.py:9: import copy
unused

[borenet, 2016-02-18 15:40:56]

https://codereview.chromium.org/1703663002/diff/90001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1703663002/diff/90001/PRESUBMIT.py#newcode88
PRESUBMIT.py:88: 'W0105',  # String statement has no effect.
On 2016/02/18 15:29:21, rmistry wrote:
> Out of curiosity, where did you run into this?

All of the module and function level docstrings triggered this.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/common.py
File infra/bots/common.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/common.py#ne...
infra/bots/common.py:9: import json
On 2016/02/18 15:29:21, rmistry wrote:
> Not used? I wonder why the linter did not catch this.

Done. I wonder the same.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
File infra/bots/compile_skia.isolate (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.isolate:1: {
On 2016/02/18 15:29:21, rmistry wrote:
> [For later] Putting isolate files and the top level scripts under bots/ is
> probably ok for now. If it gets to be a lot we might want to look into
creating
> subdirs.

I suspect we'll only have four:
skia_repo.isolate
compile_skia.isolate
test_skia.isolate
perf_skia.isolate

But yes, if we end up having more, let's create an isolates directory.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia.py
File infra/bots/compile_skia.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.py:10: import os
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/compile_skia...
infra/bots/compile_skia.py:11: import subprocess
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/andro...
File infra/bots/flavor/android_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/andro...
infra/bots/flavor/android_flavor.py:10: import copy
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
File infra/bots/flavor/coverage_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
infra/bots/flavor/coverage_flavor.py:9: import datetime
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/cover...
infra/bots/flavor/coverage_flavor.py:12: import ssh_devices
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/ios_f...
File infra/bots/flavor/ios_flavor.py (right):

https://codereview.chromium.org/1703663002/diff/90001/infra/bots/flavor/ios_f...
infra/bots/flavor/ios_flavor.py:9: import copy
On 2016/02/18 15:29:21, rmistry wrote:
> unused

Done.

[borenet, 2016-02-18 15:43:14]

The CQ bit was checked by borenet@google.com

[borenet, 2016-02-18 15:43:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/1703663002/#ps110001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-18 15:43:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703663002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703663002/110001

[commit-bot: I haz the power, 2016-02-18 16:05:51]

Description was changed from

==========
Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d9fa758292462c4200231f49286aa97750f5e689
==========

[commit-bot: I haz the power, 2016-02-18 16:05:52]

Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/d9fa758292462c4200231f49286aa97750f5e689