Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(24)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: infra/bots/compile_skia.isolate
Issue
1703663002
:
Port Skia recipe to normal Python scripts, move to Skia repo (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments
Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
PRESUBMIT.py
infra/bots/README.md
infra/bots/common.py
infra/bots/compile_skia.isolate
infra/bots/compile_skia.py
infra/bots/flavor/__init__.py
infra/bots/flavor/android_devices.py
infra/bots/flavor/android_flavor.py
infra/bots/flavor/chromeos_flavor.py
infra/bots/flavor/cmake_flavor.py
infra/bots/flavor/coverage_flavor.py
infra/bots/flavor/default_flavor.py
infra/bots/flavor/ios_flavor.py
infra/bots/flavor/ssh_devices.py
infra/bots/flavor/ssh_flavor.py
infra/bots/flavor/valgrind_flavor.py
infra/bots/flavor/xsan_flavor.py
infra/bots/skia_repo.isolate
View unified diff
|
Download patch
« no previous file with comments
|
« infra/bots/common.py
('k') |
infra/bots/compile_skia.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
'includes': [
3
'skia_repo.isolate',
4
],
5
'variables': {
6
'command': [
7
'python', 'compile_skia.py', '<(BUILDER_NAME)', '${ISOLATED_OUTDIR}/out',
8
],
9
},
10
}
OLD
NEW
« no previous file with comments
|
« infra/bots/common.py
('k') |
infra/bots/compile_skia.py »
('j') |
no next file with comments »
Issue 1703663002: Port Skia recipe to normal Python scripts, move to Skia repo (Closed)
Created 4 years, 10 months ago by borenet
Modified 4 years, 10 months ago
Reviewers: rmistry
Base URL: https://skia.googlesource.com/skia.git@master
Comments: 18
This is Rietveld
408576698