Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17035010: Revert "Rename DOMWindow interface to Window" (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, alecflett, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, dgrogan, adamk+blink_chromium.org, haraken, Nate Chapin, jsbell
Visibility:
Public.

Description

Revert "Rename DOMWindow interface to Window" This reverts commit d6a68706fcad82b56cf6e3f37073f4663e668edf. It broke clean builds. TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -2149 lines) Patch
M Source/bindings/bindings.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/derived_sources.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 25 chunks +47 lines, -60 lines 0 comments Download
M Source/bindings/scripts/generate-bindings.pl View 5 chunks +11 lines, -19 lines 0 comments Download
M Source/bindings/scripts/preprocess_idls.py View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptController.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/ScriptEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
A + Source/bindings/v8/V8DOMWindowShell.h View 7 chunks +11 lines, -11 lines 0 comments Download
A + Source/bindings/v8/V8DOMWindowShell.cpp View 18 chunks +34 lines, -34 lines 0 comments Download
M Source/bindings/v8/V8DOMWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8EventListenerList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
D Source/bindings/v8/V8WindowShell.h View 1 chunk +0 lines, -114 lines 0 comments Download
D Source/bindings/v8/V8WindowShell.cpp View 1 chunk +0 lines, -512 lines 0 comments Download
A + Source/bindings/v8/custom/V8DOMWindowCustom.cpp View 19 chunks +48 lines, -45 lines 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8SVGDocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SVGPathSegCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download
D Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -598 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/CompositionEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/KeyboardEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageEvent.idl View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/MouseEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UIEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/WheelEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/page/DOMWindow.idl View 4 chunks +11 lines, -11 lines 0 comments Download
A + Source/core/page/DOMWindowPagePopup.idl View 1 chunk +2 lines, -3 lines 0 comments Download
D Source/core/page/Window.idl View 1 chunk +0 lines, -320 lines 0 comments Download
D Source/core/page/WindowPagePopup.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/crypto/DOMWindowCrypto.idl View 1 chunk +1 line, -3 lines 0 comments Download
D Source/modules/crypto/WindowCrypto.idl View 1 chunk +0 lines, -31 lines 0 comments Download
A + Source/modules/filesystem/DOMWindowFileSystem.idl View 1 chunk +1 line, -3 lines 0 comments Download
D Source/modules/filesystem/WindowFileSystem.idl View 1 chunk +0 lines, -38 lines 0 comments Download
A + Source/modules/indexeddb/DOMWindowIndexedDatabase.idl View 1 chunk +1 line, -3 lines 0 comments Download
D Source/modules/indexeddb/WindowIndexedDatabase.idl View 1 chunk +0 lines, -33 lines 0 comments Download
A + Source/modules/mediasource/DOMWindowMediaSource.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/modules/mediasource/WindowMediaSource.idl View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/modules/modules.gypi View 9 chunks +8 lines, -8 lines 0 comments Download
A + Source/modules/notifications/DOMWindowNotifications.idl View 1 chunk +2 lines, -3 lines 0 comments Download
D Source/modules/notifications/WindowNotifications.idl View 1 chunk +0 lines, -35 lines 0 comments Download
A + Source/modules/quota/DOMWindowQuota.idl View 1 chunk +1 line, -3 lines 0 comments Download
D Source/modules/quota/WindowQuota.idl View 1 chunk +0 lines, -31 lines 0 comments Download
A + Source/modules/speech/DOMWindowSpeechSynthesis.idl View 1 chunk +2 lines, -3 lines 0 comments Download
D Source/modules/speech/WindowSpeechSynthesis.idl View 1 chunk +0 lines, -31 lines 0 comments Download
A + Source/modules/webdatabase/DOMWindowWebDatabase.idl View 1 chunk +1 line, -3 lines 0 comments Download
D Source/modules/webdatabase/WindowWebDatabase.idl View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-14 15:54:01 UTC) #1
do-not-use
On 2013/06/14 15:54:01, Christophe Dumez wrote: This is because DOMWindow is an EventTarget and we ...
7 years, 6 months ago (2013-06-14 15:55:46 UTC) #2
do-not-use
7 years, 6 months ago (2013-06-14 16:00:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r152456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698