Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: src/effects/SkBlurMaskFilter.cpp

Issue 17035007: Fix quickReject computation for blurs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: updated Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/effects/SkBlurMask.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkBlurMaskFilter.cpp
===================================================================
--- src/effects/SkBlurMaskFilter.cpp (revision 10409)
+++ src/effects/SkBlurMaskFilter.cpp (working copy)
@@ -60,7 +60,7 @@
// To avoid unseemly allocation requests (esp. for finite platforms like
// handset) we limit the radius so something manageable. (as opposed to
// a request like 10,000)
- static const SkScalar kMAX_RADIUS;
+ static const SkScalar kMAX_BLUR_RADIUS;
// This constant approximates the scaling done in the software path's
// "high quality" mode, in SkBlurMask::Blur() (1 / sqrt(3)).
// IMHO, it actually should be 1: we blur "less" than we should do
@@ -82,15 +82,15 @@
SkScalar xformedRadius = ignoreTransform ? fRadius
: ctm.mapRadius(fRadius);
- return SkMinScalar(xformedRadius, kMAX_RADIUS);
+ return SkMinScalar(xformedRadius, kMAX_BLUR_RADIUS);
}
#endif
typedef SkMaskFilter INHERITED;
};
-const SkScalar SkBlurMaskFilterImpl::kMAX_RADIUS = SkIntToScalar(128);
-const SkScalar SkBlurMaskFilterImpl::kBLUR_SIGMA_SCALE = 0.6f;
+const SkScalar SkBlurMaskFilterImpl::kMAX_BLUR_RADIUS = SkIntToScalar(128);
+const SkScalar SkBlurMaskFilterImpl::kBLUR_SIGMA_SCALE = SkFloatToScalar(0.6f);
SkMaskFilter* SkBlurMaskFilter::Create(SkScalar radius,
SkBlurMaskFilter::BlurStyle style,
@@ -139,7 +139,7 @@
radius = matrix.mapRadius(fRadius);
}
- radius = SkMinScalar(radius, kMAX_RADIUS);
+ radius = SkMinScalar(radius, kMAX_BLUR_RADIUS);
SkBlurMask::Quality blurQuality =
(fBlurFlags & SkBlurMaskFilter::kHighQuality_BlurFlag) ?
SkBlurMask::kHigh_Quality : SkBlurMask::kLow_Quality;
@@ -158,7 +158,7 @@
radius = matrix.mapRadius(fRadius);
}
- radius = SkMinScalar(radius, kMAX_RADIUS);
+ radius = SkMinScalar(radius, kMAX_BLUR_RADIUS);
return SkBlurMask::BlurRect(dst, r, radius, (SkBlurMask::Style)fBlurStyle,
margin, createMode);
@@ -334,8 +334,27 @@
void SkBlurMaskFilterImpl::computeFastBounds(const SkRect& src,
SkRect* dst) const {
- dst->set(src.fLeft - fRadius, src.fTop - fRadius,
- src.fRight + fRadius, src.fBottom + fRadius);
+ SkScalar gpuPad, rasterPad;
+
+ {
+ // GPU path
+ SkScalar sigma = SkScalarMul(fRadius, kBLUR_SIGMA_SCALE);
+ gpuPad = sigma * 3.0f;
+ }
+
+ {
+ // raster path
+ SkScalar radius = SkScalarMul(fRadius, SkBlurMask::kBlurRadiusFudgeFactor);
+
+ radius = (radius + .5f) * 2.f;
+
+ rasterPad = SkIntToScalar(SkScalarRoundToInt(radius * 3)/2);
+ }
+
+ SkScalar pad = SkMaxScalar(gpuPad, rasterPad);
+
+ dst->set(src.fLeft - pad, src.fTop - pad,
+ src.fRight + pad, src.fBottom + pad);
}
SkBlurMaskFilterImpl::SkBlurMaskFilterImpl(SkFlattenableReadBuffer& buffer)
« no previous file with comments | « src/effects/SkBlurMask.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698