src/x64/assembler-x64.h - Issue 1703453002: [interpreter, debugger] support debug breaks via bytecode array copy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.h

Issue 1703453002: [interpreter, debugger] support debug breaks via bytecode array copy (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed last comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.h

diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h

index 2847ff2569c2d967de06334e74182dedb16e1520..e4f4fabc9ecf02f2ecc0fc05a746356c4d9ff4a6 100644

--- a/src/x64/assembler-x64.h

+++ b/src/x64/assembler-x64.h

@@ -335,7 +335,6 @@ class Immediate BASE_EMBEDDED {

public:

explicit Immediate(int32_t value) : value_(value) {}

explicit Immediate(Smi* value) {

- DCHECK(SmiValuesAre31Bits()); // Only available for 31-bit SMI.

Michael Starzinger 2016/02/22 09:37:49 Why did we need to remove this check? I seem to be

Yang 2016/02/22 12:48:43 As discussed offline, this constructor is only int

value_ = static_cast<int32_t>(reinterpret_cast<intptr_t>(value));

}

« src/objects.h ('K') | « src/runtime/runtime-debug.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »