Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: src/x64/assembler-x64.h

Issue 1703453002: [interpreter, debugger] support debug breaks via bytecode array copy (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed last comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 }; 328 };
329 329
330 330
331 // ----------------------------------------------------------------------------- 331 // -----------------------------------------------------------------------------
332 // Machine instruction Immediates 332 // Machine instruction Immediates
333 333
334 class Immediate BASE_EMBEDDED { 334 class Immediate BASE_EMBEDDED {
335 public: 335 public:
336 explicit Immediate(int32_t value) : value_(value) {} 336 explicit Immediate(int32_t value) : value_(value) {}
337 explicit Immediate(Smi* value) { 337 explicit Immediate(Smi* value) {
338 DCHECK(SmiValuesAre31Bits()); // Only available for 31-bit SMI.
Michael Starzinger 2016/02/22 09:37:49 Why did we need to remove this check? I seem to be
Yang 2016/02/22 12:48:43 As discussed offline, this constructor is only int
339 value_ = static_cast<int32_t>(reinterpret_cast<intptr_t>(value)); 338 value_ = static_cast<int32_t>(reinterpret_cast<intptr_t>(value));
340 } 339 }
341 340
342 private: 341 private:
343 int32_t value_; 342 int32_t value_;
344 343
345 friend class Assembler; 344 friend class Assembler;
346 }; 345 };
347 346
348 347
(...skipping 1858 matching lines...) Expand 10 before | Expand all | Expand 10 after
2207 Assembler* assembler_; 2206 Assembler* assembler_;
2208 #ifdef DEBUG 2207 #ifdef DEBUG
2209 int space_before_; 2208 int space_before_;
2210 #endif 2209 #endif
2211 }; 2210 };
2212 2211
2213 } // namespace internal 2212 } // namespace internal
2214 } // namespace v8 2213 } // namespace v8
2215 2214
2216 #endif // V8_X64_ASSEMBLER_X64_H_ 2215 #endif // V8_X64_ASSEMBLER_X64_H_
OLDNEW
« src/objects.h ('K') | « src/runtime/runtime-debug.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698