Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 1703413002: Move common PVer4 code into a V4ProtocolManagerUtil class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass config as pointer, instead of reference Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 18b315a8d047d6c3b46cfd70148cb74e73c293aa..c0d8eaa3f98f94cfaf4c7728511f262a89a77929 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -402,7 +402,7 @@ SafeBrowsingUIManager* SafeBrowsingService::CreateUIManager() {
}
SafeBrowsingDatabaseManager* SafeBrowsingService::CreateDatabaseManager() {
- V4GetHashProtocolConfig config = GetV4GetHashProtocolConfig();
+ V4ProtocolConfig config = GetV4ProtocolConfig();
#if defined(SAFE_BROWSING_DB_LOCAL)
return new LocalSafeBrowsingDatabaseManager(this, NULL, config);
#elif defined(SAFE_BROWSING_DB_REMOTE)
@@ -446,9 +446,9 @@ SafeBrowsingProtocolConfig SafeBrowsingService::GetProtocolConfig() const {
return config;
}
-V4GetHashProtocolConfig
-SafeBrowsingService::GetV4GetHashProtocolConfig() const {
- V4GetHashProtocolConfig config;
+V4ProtocolConfig
+SafeBrowsingService::GetV4ProtocolConfig() const {
+ V4ProtocolConfig config;
config.client_name = GetProtocolConfigClientName();
config.version = SafeBrowsingProtocolManagerHelper::Version();
config.key_param = google_apis::GetAPIKey();;
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698