chrome/browser/safe_browsing/safe_browsing_service.h - Issue 1703413002: Move common PVer4 code into a V4ProtocolManagerUtil class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1703413002: Move common PVer4 code into a V4ProtocolManagerUtil class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass config as pointer, instead of reference Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h

index 3c3435dd095b7ffe30a700c6a0307b5f4abf4919..4fef81f38045d424ca6d1ac967d5fea7fab2b080 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.h

+++ b/chrome/browser/safe_browsing/safe_browsing_service.h

@@ -58,7 +58,7 @@ class SafeBrowsingProtocolManagerDelegate;

class SafeBrowsingServiceFactory;

class SafeBrowsingUIManager;

class SafeBrowsingURLRequestContextGetter;

-struct V4GetHashProtocolConfig;

+struct V4ProtocolConfig;

#if defined(FULL_SAFE_BROWSING)

class IncidentReportingService;

@@ -105,7 +105,7 @@ class SafeBrowsingService

virtual SafeBrowsingProtocolConfig GetProtocolConfig() const;

// Create a v4 protocol config struct.

- virtual V4GetHashProtocolConfig GetV4GetHashProtocolConfig() const;

+ virtual V4ProtocolConfig GetV4ProtocolConfig() const;

// Returns the client_name field for both V3 and V4 protocol manager configs.

std::string GetProtocolConfigClientName() const;

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »