Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1703383002: - Do not repeatedly allocate and release Monitor objects. (Closed)

Created:
4 years, 10 months ago by Ivan Posva
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Do not repeatedly allocate and release Monitor objects. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/6b4885583504574643799931c552ae0d2ab09e1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/heap.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/thread_barrier.h View 4 chunks +11 lines, -7 lines 0 comments Download
M runtime/vm/thread_barrier_test.cc View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 10 months ago (2016-02-18 02:24:55 UTC) #2
siva
lgtm
4 years, 10 months ago (2016-02-18 02:33:24 UTC) #3
Ivan Posva
4 years, 10 months ago (2016-02-18 02:33:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b4885583504574643799931c552ae0d2ab09e1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698