Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Side by Side Diff: runtime/vm/thread_barrier_test.cc

Issue 1703383002: - Do not repeatedly allocate and release Monitor objects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/thread_barrier.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/random.h" 6 #include "vm/random.h"
7 #include "vm/thread_barrier.h" 7 #include "vm/thread_barrier.h"
8 #include "vm/thread_pool.h" 8 #include "vm/thread_pool.h"
9 #include "vm/unit_test.h" 9 #include "vm/unit_test.h"
10 10
(...skipping 28 matching lines...) Expand all
39 const intptr_t num_rounds_; 39 const intptr_t num_rounds_;
40 ThreadBarrier* barrier_; 40 ThreadBarrier* barrier_;
41 Random rng_; 41 Random rng_;
42 }; 42 };
43 43
44 44
45 UNIT_TEST_CASE(ThreadBarrier) { 45 UNIT_TEST_CASE(ThreadBarrier) {
46 static const intptr_t kNumTasks = 5; 46 static const intptr_t kNumTasks = 5;
47 static const intptr_t kNumRounds = 500; 47 static const intptr_t kNumRounds = 500;
48 48
49 ThreadBarrier barrier(kNumTasks + 1); 49 Monitor* monitor = new Monitor();
50 for (intptr_t i = 0; i < kNumTasks; ++i) { 50 Monitor* monitor_done = new Monitor();
51 Dart::thread_pool()->Run(new FuzzTask(kNumRounds, &barrier, i + 1)); 51 {
52 ThreadBarrier barrier(kNumTasks + 1, monitor, monitor_done);
53 for (intptr_t i = 0; i < kNumTasks; ++i) {
54 Dart::thread_pool()->Run(new FuzzTask(kNumRounds, &barrier, i + 1));
55 }
56 for (intptr_t i = 0; i < kNumRounds; ++i) {
57 barrier.Sync();
58 }
59 barrier.Exit();
52 } 60 }
53 for (intptr_t i = 0; i < kNumRounds; ++i) { 61
54 barrier.Sync(); 62 delete monitor_done;
55 } 63 delete monitor;
56 barrier.Exit();
57 } 64 }
58 65
59 } // namespace dart 66 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/thread_barrier.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698