Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 17033004: Tell IDB frontend about data loss (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove debug Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index 251b6b0f5d4e3b179f044abd07bc66b5126aa703..3af1b0bd2e5c815343248aa96980ec795449fccf 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -116,7 +116,8 @@ TEST(IndexedDBDatabaseTest, ConnectionLifecycle) {
db->OpenConnection(request1,
connection1,
transaction_id1,
- IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+ IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+ false);
jsbell 2013/06/14 20:42:58 Give the argument a default value instead of passi
dgrogan 2013/06/14 22:06:43 jar@ recently reminded me that default arguments a
EXPECT_FALSE(backing_store->HasOneRef()); // db, connection count > 0
@@ -127,7 +128,8 @@ TEST(IndexedDBDatabaseTest, ConnectionLifecycle) {
db->OpenConnection(request2,
connection2,
transaction_id2,
- IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+ IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+ false);
jsbell 2013/06/14 20:42:58 Ditto?
dgrogan 2013/06/14 22:06:43 Done.
EXPECT_FALSE(backing_store->HasOneRef()); // local and connection
@@ -185,7 +187,8 @@ TEST(IndexedDBDatabaseTest, ForcedClose) {
backend->OpenConnection(request,
connection,
upgrade_transaction_id,
- IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+ IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+ false);
jsbell 2013/06/14 20:42:58 Ditto?
dgrogan 2013/06/14 22:06:43 Done.
const int64 transaction_id = 123;
const std::vector<int64> scope;

Powered by Google App Engine
This is Rietveld 408576698