Tell IDB frontend about data loss

content/browser/indexed_db/indexed_db_database_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_database.h"
 
 #include <gtest/gtest.h>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
@@ skipping 98 matching lines @@
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
   scoped_refptr<MockIDBCallbacks> request1 = MockIDBCallbacks::Create();
   scoped_refptr<FakeIDBDatabaseCallbacks> connection1 =
       FakeIDBDatabaseCallbacks::Create();
   const int64 transaction_id1 = 1;
   db->OpenConnection(request1,
                      connection1,
                      transaction_id1,
-                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+                     false);

[jsbell, 2013/06/14 20:42:58]

Give the argument a default value instead of passing explicit false?

[dgrogan, 2013/06/14 22:06:43]

jar@ recently reminded me that default arguments are against the style guide,
though now that I read it, it recommends simply using an overload instead. Seems
reasonable.

Simulated default argument via method overload it is.

 
   EXPECT_FALSE(backing_store->HasOneRef());  // db, connection count > 0
 
   scoped_refptr<MockIDBCallbacks> request2 = MockIDBCallbacks::Create();
   scoped_refptr<FakeIDBDatabaseCallbacks> connection2 =
       FakeIDBDatabaseCallbacks::Create();
   const int64 transaction_id2 = 2;
   db->OpenConnection(request2,
                      connection2,
                      transaction_id2,
-                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+                     IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+                     false);

[jsbell, 2013/06/14 20:42:58]

Ditto?

[dgrogan, 2013/06/14 22:06:43]

Done.

 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and connection
 
   db->Close(connection1);
 
   EXPECT_FALSE(backing_store->HasOneRef());  // local and connection
 
   db->Close(connection2);
   EXPECT_TRUE(backing_store->HasOneRef());
   EXPECT_FALSE(db->BackingStore().get());
@@ skipping 37 matching lines @@
 
   scoped_refptr<MockIDBDatabaseCallbacks> connection =
       MockIDBDatabaseCallbacks::Create();
   WebIDBDatabaseImpl web_database(backend, connection);
 
   scoped_refptr<MockIDBCallbacks> request = MockIDBCallbacks::Create();
   const int64 upgrade_transaction_id = 3;
   backend->OpenConnection(request,
                           connection,
                           upgrade_transaction_id,
-                          IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
+                          IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION,
+                          false);

[jsbell, 2013/06/14 20:42:58]

Ditto?

[dgrogan, 2013/06/14 22:06:43]

Done.

 
   const int64 transaction_id = 123;
   const std::vector<int64> scope;
   web_database.createTransaction(
       transaction_id, 0, scope, indexed_db::TRANSACTION_READ_ONLY);
 
   web_database.forceClose();
 
   EXPECT_TRUE(backing_store->HasOneRef());  // local
 }
 
 }  // namespace content