Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1703203003: Don't you just feel bad every time you type 'delete'? (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't you just feel bad every time you type 'delete'? This should fix https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/4787/steps/nanobench/logs/stdio Issue introduced with feec878e8508 'Simplified linear pipeline.'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M bench/SkLinearBitmapPipelineBench.cpp View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mtklein_C
4 years, 10 months ago (2016-02-17 21:20:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703203003/1
4 years, 10 months ago (2016-02-17 21:20:06 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-17 21:20:07 UTC) #6
mtklein
4 years, 10 months ago (2016-02-17 21:46:11 UTC) #8
bungeman-skia
lgtm
4 years, 10 months ago (2016-02-17 21:48:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b65fcd42830316414fb06d9b6b3cd080021f5097
4 years, 10 months ago (2016-02-17 21:50:49 UTC) #11
herb_g
4 years, 10 months ago (2016-02-17 22:03:47 UTC) #13
lgtm

Powered by Google App Engine
This is Rietveld 408576698