Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1703203002: Remove now-unused 'result' variable from vmservice_dartium.cc, breaks build on Windows (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org, Jacob, terry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove now-unused 'result' variable from vmservice_dartium.cc, breaks build on Windows BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/447590c6f95bca5f8b8b8e8a68483779615ea56c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M runtime/bin/vmservice_dartium.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Alan Knight
Missed that result is now unused, breaks Windows.
4 years, 10 months ago (2016-02-17 20:27:20 UTC) #2
srdjan
LGTM (also breaks Mac builds)
4 years, 10 months ago (2016-02-17 20:29:07 UTC) #4
Alan Knight
4 years, 10 months ago (2016-02-17 20:30:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
447590c6f95bca5f8b8b8e8a68483779615ea56c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698