runtime/bin/vmservice_dartium.cc - Issue 1703203002: Remove now-unused 'result' variable from vmservice_dartium.cc, breaks build on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice_dartium.cc

Issue 1703203002: Remove now-unused 'result' variable from vmservice_dartium.cc, breaks build on Windows (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmservice_dartium.cc

diff --git a/runtime/bin/vmservice_dartium.cc b/runtime/bin/vmservice_dartium.cc

index e91ada6fb293d5e955125d25b601bc846be4ecff..2a9fc8f1fa18a9cffeac066da2fb3ab4f5083e9d 100644

--- a/runtime/bin/vmservice_dartium.cc

+++ b/runtime/bin/vmservice_dartium.cc

@@ -62,8 +62,6 @@ Dart_Isolate VmServiceServer::CreateIsolate(const uint8_t* snapshot_buffer) {

Builtin::SetNativeResolver(Builtin::kBuiltinLibrary);

Builtin::SetNativeResolver(Builtin::kIOLibrary);

- Dart_Handle result;

ASSERT(Dart_IsServiceIsolate(isolate));

if (!VmService::Setup(DEFAULT_VM_SERVICE_SERVER_IP,

DEFAULT_VM_SERVICE_SERVER_PORT,

« no previous file with comments | « no previous file | no next file » | no next file with comments »