Remove dependency on GURL from content/common/gpu

content/renderer/renderer_blink_platform_impl.cc

Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 27965a71fe39b3b8ccd29d86b1bd10fc26580ac5..9351342fa26ab020ee3afbeccf43a1cc061898ca 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -1038,11 +1038,8 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(
   bool lose_context_when_out_of_memory = false;
   scoped_ptr<WebGraphicsContext3DCommandBufferImpl> context(
       WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(
-          gpu_channel_host.get(),
-          attributes,
-          lose_context_when_out_of_memory,
-          blink::WebStringToGURL(attributes.topDocumentURL),
-          limits,
+          gpu_channel_host.get(), attributes, lose_context_when_out_of_memory,
+          attributes.topDocumentURL.utf8(), limits,

[piman, 2016/02/18 18:29:28]

Is this equivalent, string.utf8() vs blink::WebStringToGURL(string).spec()?
WebStringToGURL seems to treat 8-bit strings (possibly Latin-1) and utf-16
strings differently.

[Mark Dittmer, 2016/02/18 21:10:25]

I'm having trouble reasoning about StringImpl and StringUTF8Adaptor to know for
sure. It's certainly the case that if topDocumentURL isn't guaranteed to be
canonical, then we need to pay the cost of
blink::WebStringToGURL(string).spec().

I'll keep reading the code, but is there someone we could CC that would know the
answer to this?

           static_cast<WebGraphicsContext3DCommandBufferImpl*>(share_context)));
 
   // Most likely the GPU process exited and the attempt to reconnect to it