Remove dependency on GURL from content/common/gpu

content/renderer/renderer_blink_platform_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_blink_platform_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 1020 matching lines @@
   }
 
   scoped_refptr<GpuChannelHost> gpu_channel_host(
       RenderThreadImpl::current()->EstablishGpuChannelSync(
           CAUSE_FOR_GPU_LAUNCH_WEBGRAPHICSCONTEXT3DCOMMANDBUFFERIMPL_INITIALIZE));
 
   WebGraphicsContext3DCommandBufferImpl::SharedMemoryLimits limits;
   bool lose_context_when_out_of_memory = false;
   scoped_ptr<WebGraphicsContext3DCommandBufferImpl> context(
       WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(
-          gpu_channel_host.get(),
-          attributes,
-          lose_context_when_out_of_memory,
-          blink::WebStringToGURL(attributes.topDocumentURL),
-          limits,
+          gpu_channel_host.get(), attributes, lose_context_when_out_of_memory,
+          attributes.topDocumentURL.utf8(), limits,

[piman, 2016/02/18 18:29:28]

Is this equivalent, string.utf8() vs blink::WebStringToGURL(string).spec()?
WebStringToGURL seems to treat 8-bit strings (possibly Latin-1) and utf-16
strings differently.

[Mark Dittmer, 2016/02/18 21:10:25]

I'm having trouble reasoning about StringImpl and StringUTF8Adaptor to know for
sure. It's certainly the case that if topDocumentURL isn't guaranteed to be
canonical, then we need to pay the cost of
blink::WebStringToGURL(string).spec().

I'll keep reading the code, but is there someone we could CC that would know the
answer to this?

           static_cast<WebGraphicsContext3DCommandBufferImpl*>(share_context)));
 
   // Most likely the GPU process exited and the attempt to reconnect to it
   // failed. Need to try to restore the context again later.
   if (!context || !context->InitializeOnCurrentThread() ||
       gl_info->testFailContext) {
     // Collect Graphicsinfo if there is a context failure or it is failed
     // purposefully in case of layout tests.
     Collect3DContextInformationOnFailure(share_context, gl_info,
                                          gpu_channel_host.get());
@@ skipping 243 matching lines @@
 }
 
 //------------------------------------------------------------------------------
 
 blink::WebTrialTokenValidator*
 RendererBlinkPlatformImpl::trialTokenValidator() {
   return &trial_token_validator_;
 }
 
 }  // namespace content