Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 170313010: Revert of [telemetry] Script for finding all Telemetry dependencies. (Closed)

Created:
6 years, 10 months ago by dtu
Modified:
6 years, 10 months ago
Reviewers:
achuithb, nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of [telemetry] Script for finding all Telemetry dependencies. (https://codereview.chromium.org/103433002/) Reason for revert: May have caused a performance regression, reverting to confirm. https://code.google.com/p/chromium/issues/detail?id=345374 Original issue's description: > [telemetry] Script for finding all Telemetry dependencies. > > Given a list of Python modules, it will find all: > - bootstrap_deps folders, recursively. > - Python dependencies. > - Page sets in those modules' folders. > - Serving dirs of those page sets. > And print a list of all files, or zip them up. > > Example bot command: tools/telemetry_tools/find_dependencies -v tools/perf/run_benchmark tools/perf/run_measurement tools/perf/record_wpr content/test/gpu/run_gpu_test -z telemetry.zip > > > BUG=311380 > TEST=Ran it. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251298 TBR=nduca@chromium.org,tonyg@chromium.org,achuith@chromium.org NOTREECHECKS=true NOTRY=true BUG=311380 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -373 lines) Patch
M tools/perf/benchmarks/peacekeeper.py View 8 chunks +9 lines, -9 lines 0 comments Download
M tools/perf/generate_profile View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/record_android_profile.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/record_wpr View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/run_benchmark View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/run_measurement View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/run_tests View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/util.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/cloud_storage.py View 4 chunks +5 lines, -4 lines 0 comments Download
D tools/telemetry_tools/find_dependencies View 1 chunk +0 lines, -262 lines 0 comments Download
D tools/telemetry_tools/path_set.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/telemetry_tools/path_set_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dtu
Created Revert of [telemetry] Script for finding all Telemetry dependencies.
6 years, 10 months ago (2014-02-22 01:36:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/170313010/1
6 years, 10 months ago (2014-02-22 01:40:31 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 01:43:48 UTC) #3
Message was sent while issue was closed.
Change committed as 252723

Powered by Google App Engine
This is Rietveld 408576698