Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/telemetry/telemetry/page/cloud_storage.py

Issue 170313010: Revert of [telemetry] Script for finding all Telemetry dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/util.py ('k') | tools/telemetry_tools/find_dependencies » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/cloud_storage.py
diff --git a/tools/telemetry/telemetry/page/cloud_storage.py b/tools/telemetry/telemetry/page/cloud_storage.py
index df103c1c4414b380f9bc778553e9e09ac2579ea0..75cd11e631a2d3b8dce43dcf5e049306785b4ce2 100644
--- a/tools/telemetry/telemetry/page/cloud_storage.py
+++ b/tools/telemetry/telemetry/page/cloud_storage.py
@@ -27,7 +27,7 @@
class CloudStorageError(Exception):
@staticmethod
def _GetConfigInstructions(gsutil_path):
- if SupportsProdaccess(gsutil_path):
+ if _SupportsProdaccess(gsutil_path):
return 'Run prodaccess to authenticate.'
else:
return ('To configure your credentials:\n'
@@ -73,7 +73,7 @@
return os.path.join(_DOWNLOAD_PATH, 'gsutil')
-def FindGsutil():
+def _FindGsutil():
"""Return the gsutil executable path. If we can't find it, download it."""
# Look for a depot_tools installation.
gsutil_path = _FindExecutableInPath(
@@ -90,7 +90,7 @@
return _DownloadGsutil()
-def SupportsProdaccess(gsutil_path):
+def _SupportsProdaccess(gsutil_path):
def GsutilSupportsProdaccess():
with open(gsutil_path, 'r') as gsutil:
return 'prodaccess' in gsutil.read()
@@ -99,7 +99,8 @@
def _RunCommand(args):
- gsutil_path = FindGsutil()
+ gsutil_path = _FindGsutil()
+
gsutil = subprocess.Popen([sys.executable, gsutil_path] + args,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
stdout, stderr = gsutil.communicate()
« no previous file with comments | « tools/telemetry/telemetry/core/util.py ('k') | tools/telemetry_tools/find_dependencies » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698