Source/core/css/CSSGrammar.y - Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSGrammar.y

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSGrammar.y

diff --git a/Source/core/css/CSSGrammar.y b/Source/core/css/CSSGrammar.y

index 149ea0005960a1cb42f8fbb02e8abf770ca20993..cc4a1ebcaf8e2b45830276ba28248462aee3f258 100644

--- a/Source/core/css/CSSGrammar.y

+++ b/Source/core/css/CSSGrammar.y

@@ -84,7 +84,7 @@ using namespace HTMLNames;

MediaQueryExp* mediaQueryExp;

CSSParserValue value;

CSSParserValueList* valueList;

- Vector<OwnPtr<MediaQueryExp> >* mediaQueryExpList;

+ WillBeHeapVector<OwnPtrWillBeMember<MediaQueryExp> >* mediaQueryExpList;

tkent 2014/02/21 00:00:36 How is this union allocated? On stack?

tkent 2014/02/21 00:13:15 Ah, this is a pointer. So allocation type doesn't

StyleKeyframe* keyframe;

Vector<RefPtr<StyleKeyframe> >* keyframeRuleList;

float val;

« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | Source/core/css/MediaList.h » ('J')