Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/css/CSSGrammar.y

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | Source/core/css/MediaList.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 %{ 1 %{
2 2
3 /* 3 /*
4 * Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org) 4 * Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 App le Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 App le Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2012 Intel Corporation. All rights reserved. 8 * Copyright (C) 2012 Intel Corporation. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 CSSParserSelector* selector; 77 CSSParserSelector* selector;
78 Vector<OwnPtr<CSSParserSelector> >* selectorList; 78 Vector<OwnPtr<CSSParserSelector> >* selectorList;
79 CSSSelector::MarginBoxType marginBox; 79 CSSSelector::MarginBoxType marginBox;
80 CSSSelector::Relation relation; 80 CSSSelector::Relation relation;
81 MediaQuerySet* mediaList; 81 MediaQuerySet* mediaList;
82 MediaQuery* mediaQuery; 82 MediaQuery* mediaQuery;
83 MediaQuery::Restrictor mediaQueryRestrictor; 83 MediaQuery::Restrictor mediaQueryRestrictor;
84 MediaQueryExp* mediaQueryExp; 84 MediaQueryExp* mediaQueryExp;
85 CSSParserValue value; 85 CSSParserValue value;
86 CSSParserValueList* valueList; 86 CSSParserValueList* valueList;
87 Vector<OwnPtr<MediaQueryExp> >* mediaQueryExpList; 87 WillBeHeapVector<OwnPtrWillBeMember<MediaQueryExp> >* mediaQueryExpList;
tkent 2014/02/21 00:00:36 How is this union allocated? On stack?
tkent 2014/02/21 00:13:15 Ah, this is a pointer. So allocation type doesn't
88 StyleKeyframe* keyframe; 88 StyleKeyframe* keyframe;
89 Vector<RefPtr<StyleKeyframe> >* keyframeRuleList; 89 Vector<RefPtr<StyleKeyframe> >* keyframeRuleList;
90 float val; 90 float val;
91 CSSPropertyID id; 91 CSSPropertyID id;
92 CSSParserLocation location; 92 CSSParserLocation location;
93 } 93 }
94 94
95 %{ 95 %{
96 96
97 static inline int cssyyerror(void*, const char*) 97 static inline int cssyyerror(void*, const char*)
(...skipping 1797 matching lines...) Expand 10 before | Expand all | Expand 10 after
1895 1895
1896 rule_error_recovery: 1896 rule_error_recovery:
1897 /* empty */ 1897 /* empty */
1898 | rule_error_recovery error 1898 | rule_error_recovery error
1899 | rule_error_recovery invalid_square_brackets_block 1899 | rule_error_recovery invalid_square_brackets_block
1900 | rule_error_recovery invalid_parentheses_block 1900 | rule_error_recovery invalid_parentheses_block
1901 ; 1901 ;
1902 1902
1903 %% 1903 %%
1904 1904
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | Source/core/css/MediaList.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698