Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 170263006: Fix webpagereplay.py so that dns_port can be None. (Closed)

Created:
6 years, 10 months ago by craigdh
Modified:
6 years, 10 months ago
Reviewers:
frankf
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Fix webpagereplay.py so that dns_port can be None. BUG=339878 NOTRY=True R=frankf@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/test/functional/webpagereplay.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
craigdh
6 years, 10 months ago (2014-02-19 21:00:43 UTC) #1
frankf
lgtm
6 years, 10 months ago (2014-02-19 21:03:35 UTC) #2
craigdh
6 years, 10 months ago (2014-02-19 21:10:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r252086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698