Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8562)

Unified Diff: chrome/test/functional/webpagereplay.py

Issue 170263006: Fix webpagereplay.py so that dns_port can be None. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/webpagereplay.py
diff --git a/chrome/test/functional/webpagereplay.py b/chrome/test/functional/webpagereplay.py
index ef724ed43073303a9a798ae2c3b5782fb58992b6..8d115ef322f80757832e72b360fe542f06f6e451 100755
--- a/chrome/test/functional/webpagereplay.py
+++ b/chrome/test/functional/webpagereplay.py
@@ -94,7 +94,8 @@ class ReplayServer(object):
archive_path: a path to a specific WPR archive (required).
replay_host: the hostname to serve traffic.
dns_port: an integer port on which to serve DNS traffic. May be zero
- to let the OS choose an available port.
+ to let the OS choose an available port. If None DNS forwarding is
+ disabled.
http_port: an integer port on which to serve HTTP traffic. May be zero
to let the OS choose an available port.
https_port: an integer port on which to serve HTTPS traffic. May be zero
@@ -133,12 +134,13 @@ class ReplayServer(object):
self.replay_options = [
'--host', str(self._replay_host),
'--port', str(self.http_port),
- '--dns_port', str(self.dns_port),
'--ssl_port', str(self.https_port),
'--use_closest_match',
'--no-dns_forwarding',
'--log_level', 'warning'
] + self.replay_options
+ if self.dns_port is not None:
+ self.replay_options.extend(['--dns_port', str(self.dns_port)])
def _CheckPath(self, label, path):
if not os.path.exists(path):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698