Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 1702593002: More simplification and unification of frame handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/frame.h ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
11 #include "src/compiler/osr.h" 11 #include "src/compiler/osr.h"
12 #include "src/frames.h"
12 #include "src/ia32/assembler-ia32.h" 13 #include "src/ia32/assembler-ia32.h"
13 #include "src/ia32/frames-ia32.h" 14 #include "src/ia32/frames-ia32.h"
14 #include "src/ia32/macro-assembler-ia32.h" 15 #include "src/ia32/macro-assembler-ia32.h"
15 16
16 namespace v8 { 17 namespace v8 {
17 namespace internal { 18 namespace internal {
18 namespace compiler { 19 namespace compiler {
19 20
20 #define __ masm()-> 21 #define __ masm()->
21 22
(...skipping 27 matching lines...) Expand all
49 } 50 }
50 DCHECK(op->IsStackSlot() || op->IsDoubleStackSlot()); 51 DCHECK(op->IsStackSlot() || op->IsDoubleStackSlot());
51 FrameOffset offset = frame_access_state()->GetFrameOffset( 52 FrameOffset offset = frame_access_state()->GetFrameOffset(
52 AllocatedOperand::cast(op)->index()); 53 AllocatedOperand::cast(op)->index());
53 return Operand(offset.from_stack_pointer() ? esp : ebp, 54 return Operand(offset.from_stack_pointer() ? esp : ebp,
54 offset.offset() + extra); 55 offset.offset() + extra);
55 } 56 }
56 57
57 Operand ToMaterializableOperand(int materializable_offset) { 58 Operand ToMaterializableOperand(int materializable_offset) {
58 FrameOffset offset = frame_access_state()->GetFrameOffset( 59 FrameOffset offset = frame_access_state()->GetFrameOffset(
59 Frame::FPOffsetToSlot(materializable_offset)); 60 FPOffsetToFrameSlot(materializable_offset));
60 return Operand(offset.from_stack_pointer() ? esp : ebp, offset.offset()); 61 return Operand(offset.from_stack_pointer() ? esp : ebp, offset.offset());
61 } 62 }
62 63
63 Operand HighOperand(InstructionOperand* op) { 64 Operand HighOperand(InstructionOperand* op) {
64 DCHECK(op->IsDoubleStackSlot()); 65 DCHECK(op->IsDoubleStackSlot());
65 return ToOperand(op, kPointerSize); 66 return ToOperand(op, kPointerSize);
66 } 67 }
67 68
68 Immediate ToImmediate(InstructionOperand* operand) { 69 Immediate ToImmediate(InstructionOperand* operand) {
69 Constant constant = ToConstant(operand); 70 Constant constant = ToConstant(operand);
(...skipping 1664 matching lines...) Expand 10 before | Expand all | Expand 10 after
1734 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 1735 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
1735 __ Nop(padding_size); 1736 __ Nop(padding_size);
1736 } 1737 }
1737 } 1738 }
1738 1739
1739 #undef __ 1740 #undef __
1740 1741
1741 } // namespace compiler 1742 } // namespace compiler
1742 } // namespace internal 1743 } // namespace internal
1743 } // namespace v8 1744 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/frame.h ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698