Issue 170253005: CloudPolicyValidator::ValidateCachedKey() generates errors on empty signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170253005: CloudPolicyValidator::ValidateCachedKey() generates errors on empty signatures. (Closed)

Created:
6 years, 10 months ago by Andrew T Wilson (Slow)

Modified:
6 years, 10 months ago

Reviewers:
dconnelly

CC:
chromium-reviews, palmer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

CloudPolicyValidator::ValidateCachedKey() generates errors on empty signatures. Added more CloudPolicyValidator unittests. BUG=275291 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251772

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -3 lines)			Patch
	M	components/policy/core/common/cloud/cloud_policy_validator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/policy/core/common/cloud/cloud_policy_validator_unittest.cc	View		4 chunks	+23 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Andrew T Wilson (Slow)

PTAL. This fixes an issue that palmer@ noted in his review of a previous CL, ...

6 years, 10 months ago (2014-02-18 10:19:42 UTC) #1

Andrew T Wilson (Slow)

The CQ bit was checked by atwilson@chromium.org

6 years, 10 months ago (2014-02-18 12:19:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/170253005/1

6 years, 10 months ago (2014-02-18 12:19:59 UTC) #4

Message was sent while issue was closed.

Change committed as 251772