components/policy/core/common/cloud/cloud_policy_validator.cc - Issue 170253005: CloudPolicyValidator::ValidateCachedKey() generates errors on empty signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator.cc

Issue 170253005: CloudPolicyValidator::ValidateCachedKey() generates errors on empty signatures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/policy/core/common/cloud/cloud_policy_validator.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_validator.cc b/components/policy/core/common/cloud/cloud_policy_validator.cc

index b6fafab149e26e3b9120c55e0ef3be1a9274f3e0..2774b0995626c9bd8612a35d9e462a29a2ec83ca 100644

--- a/components/policy/core/common/cloud/cloud_policy_validator.cc

+++ b/components/policy/core/common/cloud/cloud_policy_validator.cc

@@ -391,7 +391,7 @@ CloudPolicyValidatorBase::Status CloudPolicyValidatorBase::CheckInitialKey() {

}

CloudPolicyValidatorBase::Status CloudPolicyValidatorBase::CheckCachedKey() {

- if (!cached_key_signature_.empty() && !verification_key_.empty() &&

+ if (!verification_key_.empty() &&

!CheckVerificationKeySignature(cached_key_, verification_key_,

cached_key_signature_)) {

LOG(ERROR) << "Cached key signature verification failed";

« no previous file with comments | « no previous file | components/policy/core/common/cloud/cloud_policy_validator_unittest.cc » ('j') | no next file with comments »