Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 170243007: [webcrypto] Make all of the crypto.subtle method failures asynchronous. (Closed)

Created:
6 years, 10 months ago by eroman
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[webcrypto] Make all of the crypto.subtle method failures asynchronous. This matches the spec update https://dvcs.w3.org/hg/webcrypto-api/rev/4bd9e8dbe699 Background: The crypto.subtle methods all return a Promise. Rather than throwing exceptions for certain types of invalid/unsupported input but not others, the Promise is now consistently rejected. Web IDL errors are not affected and will still throw exceptions like before. Specifically this changelist makes it so: * No longer throws NotSupportedError [1] * No longer throws when given an unrecognized/unsupported KeyFormat or KeyUsage [1] It used to do this when the algorithm name was unrecognized, or the algorithm didn't support the requested operation. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -113 lines) Patch
M LayoutTests/crypto/digest.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/digest-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/crypto/exportKey.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/crypto/exportKey-expected.txt View 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/crypto/generateKey.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/generateKey-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/crypto/importKey.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/crypto/importKey-expected.txt View 2 chunks +8 lines, -4 lines 0 comments Download
M LayoutTests/crypto/sign-verify.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/sign-verify-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/crypto/wrap-unwrap.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/crypto/wrap-unwrap-expected.txt View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/modules/crypto/Key.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/crypto/Key.cpp View 5 chunks +10 lines, -8 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 6 chunks +12 lines, -13 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 13 chunks +36 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
6 years, 10 months ago (2014-02-21 02:22:59 UTC) #1
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-21 07:44:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/170243007/1
6 years, 10 months ago (2014-02-21 07:45:04 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 10:54:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28282
6 years, 10 months ago (2014-02-21 10:54:52 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 10 months ago (2014-02-21 19:27:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/170243007/1
6 years, 10 months ago (2014-02-21 19:27:43 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 20:20:00 UTC) #8
Message was sent while issue was closed.
Change committed as 167611

Powered by Google App Engine
This is Rietveld 408576698