Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: Source/modules/crypto/NormalizeAlgorithm.h

Issue 170243007: [webcrypto] Make all of the crypto.subtle method failures asynchronous. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/crypto/Key.cpp ('k') | Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/crypto/NormalizeAlgorithm.h
diff --git a/Source/modules/crypto/NormalizeAlgorithm.h b/Source/modules/crypto/NormalizeAlgorithm.h
index a02e36259e6748ecb6194f3de8051775888e3cf1..abfbc26e86c2c5b3aa5f643f8d8ca6a8e2ec1f50 100644
--- a/Source/modules/crypto/NormalizeAlgorithm.h
+++ b/Source/modules/crypto/NormalizeAlgorithm.h
@@ -39,8 +39,8 @@ namespace blink { class WebCryptoAlgorithm; }
namespace WebCore {
+class CryptoResult;
class Dictionary;
-class ExceptionState;
enum AlgorithmOperation {
Encrypt,
@@ -64,13 +64,11 @@ enum AlgorithmOperation {
//
// On success returns true and sets the WebCryptoAlgorithm.
//
-// On failure parseAlgorithm returns false. errorDetails will be filled
-// with a (non-localized) debug string. Additionally the ExceptionState *may*
-// be set (the web crypto spec only defines a handeful of errors as resulting
-// in exceptions).
+// On failure parseAlgorithm returns false and completes the CryptoResult
+// with a (non-localized) debug string.
//
// [1] http://www.w3.org/TR/WebCryptoAPI/#algorithm-normalizing-rules
-bool parseAlgorithm(const Dictionary&, AlgorithmOperation, blink::WebCryptoAlgorithm&, String& errorDetails, ExceptionState&) WARN_UNUSED_RETURN;
+bool parseAlgorithm(const Dictionary&, AlgorithmOperation, blink::WebCryptoAlgorithm&, CryptoResult*) WARN_UNUSED_RETURN;
// Returns a null-terminated C-string literal. Caller can assume the pointer
// will be valid for the program's entire runtime.
« no previous file with comments | « Source/modules/crypto/Key.cpp ('k') | Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698