Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1702233002: Editing: Make the |EditingState*| argument of CompositeEditCommand::insertNodeAt mandatory. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Make the |EditingState*| argument of CompositeEditCommand::insertNodeAt mandatory. This CL has no tests. We're not sure if this CL makes user-visible behavior changes. The purpose of this CL is to reduce ClusterFuzz crashes in the future. BUG=586846 Committed: https://crrev.com/8fa61a69304e774ec9e4c1e944a2fc151c02c0ab Cr-Commit-Position: refs/heads/master@{#375738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 3 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 8 chunks +18 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-02-17 00:46:19 UTC) #2
yosin_UTC9
lgtm
4 years, 10 months ago (2016-02-17 01:09:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702233002/1
4 years, 10 months ago (2016-02-17 01:10:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 01:23:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 01:25:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fa61a69304e774ec9e4c1e944a2fc151c02c0ab
Cr-Commit-Position: refs/heads/master@{#375738}

Powered by Google App Engine
This is Rietveld 408576698