third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h - Issue 1702233002: Editing: Make the |EditingState*| argument of CompositeEditCommand::insertNodeAt mandatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

Issue 1702233002: Editing: Make the |EditingState*| argument of CompositeEditCommand::insertNodeAt mandatory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

index 6b4c47ee120ca314a1659619f45ff7f50ca111a4..d83fdcd48f2c2dd209d666f85afa2eea3f7c4d47 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

@@ -48,7 +48,7 @@ private:

void doApply(EditingState*) override;

- Position positionInsideTextNode(const Position&);

+ Position positionInsideTextNode(const Position&, EditingState*);

Position insertTab(const Position&, EditingState*);

bool performTrivialReplace(const String&, bool selectInsertedText);