[css-grid] Swap columns and rows in grid-template shorthand

[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3eae5c5f9

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
Committed: https://crrev.com/3d6b5d3df0a988475328dc5a4aabce5c4f4aa211
Cr-Commit-Position: refs/heads/master@{#376325}

[Manuel Rego, 2016-02-16 16:18:08]

rego@igalia.com changed reviewers:
+ rune@opera.com, svillar@igalia.com, timloh@chromium.org

[Manuel Rego, 2016-02-16 16:18:08]

grid-template shorthand has suffered some changes
on the spec since it was implemented:
https://drafts.csswg.org/css-grid/#explicit-grid-shorthand

This patch just swaps the order of columns and rows.
Other changes will be fixed in follow-up patches.

[Manuel Rego, 2016-02-16 16:25:38]

Description was changed from

==========
[css-grid] Swap order of columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
==========

to

==========
[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
==========

[rune, 2016-02-17 14:22:21]

lgtm, but someone with more grid knowledge should take a look as well.

[Manuel Rego, 2016-02-17 15:51:22]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com

[Manuel Rego, 2016-02-17 15:51:22]

@rune thanks for the quick review!

Adding more grid reviewers. Please take a look.

[cbiesinger, 2016-02-18 21:40:07]

lgtm

[Manuel Rego, 2016-02-18 21:59:57]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-02-18 22:00:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702013003/1

[commit-bot: I haz the power, 2016-02-18 22:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 22:39:25]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Manuel Rego, 2016-02-18 22:47:55]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-02-18 22:51:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702013003/1

[commit-bot: I haz the power, 2016-02-18 23:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 23:19:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Manuel Rego, 2016-02-18 23:37:08]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-02-18 23:37:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, rune@opera.com
Link to the patchset: https://codereview.chromium.org/1702013003/#ps20001
(title: "Swap columns and rows in tests under fast/repaint/")

[commit-bot: I haz the power, 2016-02-18 23:44:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702013003/20001

[commit-bot: I haz the power, 2016-02-19 01:11:23]

Description was changed from

==========
[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
==========

to

==========
[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
==========

[commit-bot: I haz the power, 2016-02-19 01:11:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-19 01:12:26]

Description was changed from

==========
[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215
==========

to

==========
[css-grid] Swap columns and rows in grid-template shorthand

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3ea...

Updated the parsing and modified the tests to follow the new syntax.

BUG=583215

Committed: https://crrev.com/3d6b5d3df0a988475328dc5a4aabce5c4f4aa211
Cr-Commit-Position: refs/heads/master@{#376325}
==========

[commit-bot: I haz the power, 2016-02-19 01:12:27]

Patchset 2 (id:??) landed as
https://crrev.com/3d6b5d3df0a988475328dc5a4aabce5c4f4aa211
Cr-Commit-Position: refs/heads/master@{#376325}