third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1702013003: [css-grid] Swap columns and rows in grid-template shorthand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1702013003: [css-grid] Swap columns and rows in grid-template shorthand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Swap columns and rows in tests under fast/repaint/ Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/justify-self-overflow-change.html ('k') | third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index 23db75c35f064071f12a4c11a8c32b5aa89e6213..a6ac210cdf34cbee95036e52e33de7abdfccd71c 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -160,7 +160,8 @@ private:

PassRefPtrWillBeRawPtr<CSSValue> parseGridPosition();

bool parseIntegerOrCustomIdentFromGridPosition(RefPtrWillBeRawPtr<CSSPrimitiveValue>& numericValue, RefPtrWillBeRawPtr<CSSCustomIdentValue>& gridLineName);

bool parseGridItemPositionShorthand(CSSPropertyID, bool important);

- bool parseGridTemplateRowsAndAreas(PassRefPtrWillBeRawPtr<CSSValue>, bool important);

+ PassRefPtrWillBeRawPtr<CSSValue> parseGridTemplateColumns(bool important);

+ bool parseGridTemplateRowsAndAreasAndColumns(bool important);

bool parseGridTemplateShorthand(bool important);

bool parseGridShorthand(bool important);

bool parseGridAreaShorthand(bool important);