third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp - Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: InvalidatableInterpolation RefPtrs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectModel.h ('k') | third_party/WebKit/Source/core/animation/StringKeyframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

index cbc4f3f3897021615deddf62124e59d0742bdda9..d72119616524077f750daf59a382eb1f078e7537 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

@@ -235,12 +235,13 @@ Keyframe::PropertySpecificKeyframe::PropertySpecificKeyframe(double offset, Pass

, m_easing(easing)

, m_composite(composite)

{

+ ASSERT(!isNull(offset));

}

-void KeyframeEffectModelBase::PropertySpecificKeyframeGroup::appendKeyframe(PassOwnPtr<Keyframe::PropertySpecificKeyframe> keyframe)

+void KeyframeEffectModelBase::PropertySpecificKeyframeGroup::appendKeyframe(PassRefPtr<Keyframe::PropertySpecificKeyframe> keyframe)

{

ASSERT(m_keyframes.isEmpty() || m_keyframes.last()->offset() <= keyframe->offset());

- m_keyframes.append(std::move(keyframe));

+ m_keyframes.append(keyframe);

}

void KeyframeEffectModelBase::PropertySpecificKeyframeGroup::removeRedundantKeyframes()