Focus on the default browser option when opening the Win10 settings page.

Focus on the default browser option when opening the Win10 settings page.

BUG=576490
Committed: https://crrev.com/3d06b11789cd40a9ff1d0d83f3bb467beb682c8f
Cr-Commit-Position: refs/heads/master@{#375692}

[grt (UTC plus 2), 2016-02-15 19:29:35]

grt@chromium.org changed reviewers:
+ pmonette@chromium.org

[grt (UTC plus 2), 2016-02-15 19:29:36]

Hi Patrick. PTAL. Do you think this should be behind an experiment, or use a
param for the exact string? Is there a better bug # for it?

[Patrick Monette, 2016-02-15 21:22:15]

Awesome!

It's the right bug for this.

What happens if the string is empty or points to a non-existing target?

[grt (UTC plus 2), 2016-02-16 18:49:13]

Patchset #2 (id:20001) has been deleted

[grt (UTC plus 2), 2016-02-16 18:51:21]

grt@chromium.org changed reviewers:
+ asvitkine@chromium.org

[grt (UTC plus 2), 2016-02-16 18:51:22]

I've made it slightly resilient to having the wrong target. PTAL.

asvitkine: please review metrics

[Patrick Monette, 2016-02-16 19:00:02]

lgtm

[Alexei Svitkine (slow), 2016-02-16 19:09:40]

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:253: +<histogram
name="ActivateSettings.ErrorHresult" enum="Hresult">
Can this histogram be nested under an existing prefix? e.g. under Installer.*

[grt (UTC plus 2), 2016-02-16 21:08:45]

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:253: +<histogram
name="ActivateSettings.ErrorHresult" enum="Hresult">
On 2016/02/16 19:09:40, Alexei Svitkine wrote:
> Can this histogram be nested under an existing prefix? e.g. under Installer.*

I could see putting it in "Platform.*" since it's a
Cr-Internals-PlatformIntegration sort of thing. That prefix seems to be
primarily (exclusively?) used by CrOS metrics at the moment, though. Is it okay
to jump into someone else's prefix like that?

[Alexei Svitkine (slow), 2016-02-16 21:25:54]

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:253: +<histogram
name="ActivateSettings.ErrorHresult" enum="Hresult">
On 2016/02/16 21:08:45, grt wrote:
> On 2016/02/16 19:09:40, Alexei Svitkine wrote:
> > Can this histogram be nested under an existing prefix? e.g. under
Installer.*
> 
> I could see putting it in "Platform.*" since it's a
> Cr-Internals-PlatformIntegration sort of thing. That prefix seems to be
> primarily (exclusively?) used by CrOS metrics at the moment, though. Is it
okay
> to jump into someone else's prefix like that?

Yeah Platform has been used for CrOS so I think it would be confusing to put
other stuff there. Maybe just put it under Windows.*?

[grt (UTC plus 2), 2016-02-16 21:25:59]

PTAL

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1701783002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:253: +<histogram
name="ActivateSettings.ErrorHresult" enum="Hresult">
On 2016/02/16 21:08:45, grt wrote:
> On 2016/02/16 19:09:40, Alexei Svitkine wrote:
> > Can this histogram be nested under an existing prefix? e.g. under
Installer.*
> 
> I could see putting it in "Platform.*" since it's a
> Cr-Internals-PlatformIntegration sort of thing. That prefix seems to be
> primarily (exclusively?) used by CrOS metrics at the moment, though. Is it
okay
> to jump into someone else's prefix like that?

I've moved it under "DefaultBrowser." after pmonette's excellent suggestion.

[grt (UTC plus 2), 2016-02-16 21:26:04]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 21:27:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701783002/60001

[Alexei Svitkine (slow), 2016-02-16 21:44:21]

lgtm

[grt (UTC plus 2), 2016-02-16 21:54:30]

The CQ bit was unchecked by grt@chromium.org

[grt (UTC plus 2), 2016-02-16 21:54:35]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2016-02-16 21:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pmonette@chromium.org
Link to the patchset: https://codereview.chromium.org/1701783002/#ps60001
(title: "histogram under DefaultBrowser.")

[commit-bot: I haz the power, 2016-02-16 21:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701783002/60001

[commit-bot: I haz the power, 2016-02-16 22:55:14]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-16 22:57:12]

Description was changed from

==========
Focus on the default browser option when opening the Win10 settings page.

BUG=576490
==========

to

==========
Focus on the default browser option when opening the Win10 settings page.

BUG=576490

Committed: https://crrev.com/3d06b11789cd40a9ff1d0d83f3bb467beb682c8f
Cr-Commit-Position: refs/heads/master@{#375692}
==========

[commit-bot: I haz the power, 2016-02-16 22:57:13]

Patchset 3 (id:??) landed as
https://crrev.com/3d06b11789cd40a9ff1d0d83f3bb467beb682c8f
Cr-Commit-Position: refs/heads/master@{#375692}