Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1701423002: Mojo C++ bindings: support sync methods - part 1. (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: support sync methods - part 1. This CL: - adds support for [Sync] attribute; - generates C++ sync method signatures; - does the simplest thing to block and wait for results of sync calls. (Allows any messages of the same interface ptr to re-enter; disallows any messages of other message pipes to re-enter.) The following will be in future CLs: - Change the re-entrancy behavior. - Support sync calls with associated interfaces. BUG=577699 Committed: https://crrev.com/904b45f35fb925bab31d25e43732a947385460b6 Cr-Commit-Position: refs/heads/master@{#376023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -38 lines) Patch
M mojo/mojo_edk_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_builder.h View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_internal.h View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 5 chunks +47 lines, -20 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/test_sync_methods.mojom View 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 8 chunks +82 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
4 years, 10 months ago (2016-02-17 18:50:35 UTC) #2
jam
lgtm
4 years, 10 months ago (2016-02-17 23:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701423002/1
4 years, 10 months ago (2016-02-17 23:07:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 23:16:08 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 23:17:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/904b45f35fb925bab31d25e43732a947385460b6
Cr-Commit-Position: refs/heads/master@{#376023}

Powered by Google App Engine
This is Rietveld 408576698