mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl - Issue 1701423002: Mojo C++ bindings: support sync methods - part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl

Issue 1701423002: Mojo C++ bindings: support sync methods - part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_sync_methods.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl

index 7b4bab2fb0926b85410225f4c5befe369fcff692..7bc6d6cbde9468cd67d20f1ca5dece4a6a889039 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl

@@ -45,6 +45,15 @@ class {{interface.name}} {

{%- for method in interface.methods %}

{% if method.response_parameters != None %}

+{%- if method.sync %}

+ virtual bool {{method.name}}({{interface_macros.declare_sync_method_params("", method)}}) {

+ // Sync method. This signature is used by the client side; the service side

+ // should implement the signature with callback below.

+ NOTREACHED();

+ return false;

+ }

+{%- endif %}

using {{method.name}}Callback = {{interface_macros.declare_callback(method)}};

{%- endif %}

virtual void {{method.name}}({{interface_macros.declare_request_params("", method)}}) = 0;