Remove 6-param applyCropRect() from lighting filters (raster path).

Remove 6-param applyCropRect() from lighting filters (raster path).

BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701133002

Committed: https://skia.googlesource.com/skia/+/84f0e745839a0cb5ff5055f5ea0726bdd83b920b

[Stephen White, 2016-02-16 19:06:50]

Description was changed from

==========
Image filters: Remove 6-param applyCropRect() from lighting filters.

BUG=skia:4502
==========

to

==========
Image filters: Remove 6-param applyCropRect() from lighting filters.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-16 20:02:54]

Description was changed from

==========
Image filters: Remove 6-param applyCropRect() from lighting filters.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Image filters: Remove 6-param applyCropRect() from lighting filters.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-16 20:02:54]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2016-02-16 20:03:13]

Description was changed from

==========
Image filters: Remove 6-param applyCropRect() from lighting filters.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Image filters: Remove 6-param applyCropRect() from lighting filters (raster).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-16 20:03:52]

Description was changed from

==========
Image filters: Remove 6-param applyCropRect() from lighting filters (raster).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (raster).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-16 20:04:15]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (raster).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (raster path).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-16 20:04:21]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 20:04:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701133002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701133002/100001

[Stephen White, 2016-02-16 20:04:45]

Rob: PTAL. Thanks!

[robertphillips, 2016-02-16 20:19:46]

lgtm + nits

https://codereview.chromium.org/1701133002/diff/100001/gm/imagefilterscropexp...
File gm/imagefilterscropexpand.cpp (right):

https://codereview.chromium.org/1701133002/diff/100001/gm/imagefilterscropexp...
gm/imagefilterscropexpand.cpp:79: SkIntToScalar(outset));
bigRect ?

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:190: public:
Fetch ?

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:195: 
// The DecalPixelFetcher is used to implement the cropRect for the Raster path

?

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:197: public:
Fetch ?

[commit-bot: I haz the power, 2016-02-16 20:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 20:31:53]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-02-16 20:54:08]

https://codereview.chromium.org/1701133002/diff/100001/gm/imagefilterscropexp...
File gm/imagefilterscropexpand.cpp (right):

https://codereview.chromium.org/1701133002/diff/100001/gm/imagefilterscropexp...
gm/imagefilterscropexpand.cpp:79: SkIntToScalar(outset));
On 2016/02/16 20:19:46, robertphillips wrote:
> bigRect ?

Done.

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:190: public:
On 2016/02/16 20:19:46, robertphillips wrote:
> Fetch ?

Done.

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:195: 
On 2016/02/16 20:19:46, robertphillips wrote:
> // The DecalPixelFetcher is used to implement the cropRect for the Raster path
> 
> ?

Almost; done. :)

https://codereview.chromium.org/1701133002/diff/100001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:197: public:
On 2016/02/16 20:19:46, robertphillips wrote:
> Fetch ?

Done.

[Stephen White, 2016-02-16 20:55:18]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-02-16 20:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1701133002/#ps120001
(title: "Changes per review")

[commit-bot: I haz the power, 2016-02-16 20:55:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701133002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701133002/120001

[commit-bot: I haz the power, 2016-02-16 21:26:58]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (raster path).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (raster path).

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/84f0e745839a0cb5ff5055f5ea0726bdd83b920b
==========

[commit-bot: I haz the power, 2016-02-16 21:26:59]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/84f0e745839a0cb5ff5055f5ea0726bdd83b920b