Remove 6-param applyCropRect() from lighting filters (GPU path).

Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are not contained within the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698913004

Committed: https://skia.googlesource.com/skia/+/9bd5f746ca45ebec0ed3b54dcbd6cf5fc2754c3c

[Stephen White, 2016-02-16 20:58:10]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect.

BUG=skia:4502
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-17 16:31:19]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are
larger than the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-17 16:31:45]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are
larger than the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are not
contained within the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-17 16:31:46]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2016-02-17 16:31:56]

Rob: PTAL. Thanks!

[Stephen White, 2016-02-17 16:32:18]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 16:32:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698913004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698913004/120001

[commit-bot: I haz the power, 2016-02-17 17:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 17:01:12]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-17 18:05:45]

lgtm

https://codereview.chromium.org/1698913004/diff/120001/src/effects/SkLighting...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1698913004/diff/120001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:1801: temp.appendf("temp%d", index);
We don't need the '\n's and '\t's anymore with the pretty printer.

[Stephen White, 2016-02-17 18:26:14]

https://codereview.chromium.org/1698913004/diff/120001/src/effects/SkLighting...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1698913004/diff/120001/src/effects/SkLighting...
src/effects/SkLightingImageFilter.cpp:1801: temp.appendf("temp%d", index);
On 2016/02/17 18:05:45, robertphillips wrote:
> We don't need the '\n's and '\t's anymore with the pretty printer.

Acknowledged.

[Stephen White, 2016-02-17 18:27:41]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-02-17 18:27:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1698913004/#ps140001
(title: "Fix whitespace, bugs")

[commit-bot: I haz the power, 2016-02-17 18:27:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698913004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698913004/140001

[commit-bot: I haz the power, 2016-02-17 18:59:50]

Description was changed from

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are not
contained within the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove 6-param applyCropRect() from lighting filters (GPU path).

This required adding a texture domain effect if the destination bounds are not
contained within the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9bd5f746ca45ebec0ed3b54dcbd6cf5fc2754c3c
==========

[commit-bot: I haz the power, 2016-02-17 18:59:50]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/9bd5f746ca45ebec0ed3b54dcbd6cf5fc2754c3c