Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: net/url_request/url_request_http_job_unittest.cc

Issue 1701063002: CookieStore: Remove reference counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadsafe
Patch Set: Small fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index a6fc7eb720532d16b7336e0ee43b5b5561143935..5cef19cf979177c387750d021cce9acb40e3151e 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -544,7 +544,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest, BackoffHeaderCachedResponse) {
}
TEST_F(URLRequestHttpJobTest, TestCancelWhileReadingCookies) {
- context_.set_cookie_store(new DelayedCookieMonster());
+ DelayedCookieMonster cookie_monster;
+ context_.set_cookie_store(&cookie_monster);
Randy Smith (Not in Mondays) 2016/03/01 20:48:43 Same issue mentioned elsewhere about a context raw
mmenke 2016/03/01 22:44:45 What I think is uglier than the lifetime issue her
TestDelegate delegate;
scoped_ptr<URLRequest> request = context_.CreateRequest(

Powered by Google App Engine
This is Rietveld 408576698