CookieStore: Remove reference counting.

net/url_request/url_request_http_job_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include <stdint.h>
 
 #include <cstddef>
 
@@ skipping 526 matching lines @@
 
   request2->Start();
   ASSERT_TRUE(request2->is_pending());
   base::RunLoop().Run();
   EXPECT_TRUE(request2->was_cached());
   EXPECT_TRUE(request2->status().is_success());
   EXPECT_EQ(0, delegate2.received_before_network_start_count());
 }
 
 TEST_F(URLRequestHttpJobTest, TestCancelWhileReadingCookies) {
-  context_.set_cookie_store(new DelayedCookieMonster());
+  DelayedCookieMonster cookie_monster;
+  context_.set_cookie_store(&cookie_monster);

[Randy Smith (Not in Mondays), 2016/03/01 20:48:43]

Same issue mentioned elsewhere about a context raw pointer outliving the object
pointed to (by a little bit).  I'm inclined to suggest that you set the cookie
store to null (or save the pointer and reset it) in this routine, since I think
of the destructor of the URLRequestContext likely being more stable than the
destructor of a random test class.  

[mmenke, 2016/03/01 22:44:45]

What I think is uglier than the lifetime issue here is that we're modifying a
"live" URLRequestContext, after initialization.  I'd really like the
TestURLRequestContext to be able to take ownership of stuff, before we call its
initialization function, so it can wire everything up as needed.

Anyhow, I addressed both issues by just creating a new TestURLRequestContext for
this test.

 
   TestDelegate delegate;
   scoped_ptr<URLRequest> request = context_.CreateRequest(
       GURL("http://www.example.com"), DEFAULT_PRIORITY, &delegate);
 
   request->Start();
   request->Cancel();
   base::RunLoop().Run();
 
   DCHECK_EQ(0, delegate.received_before_network_start_count());
@@ skipping 377 matching lines @@
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status());
   EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called());
 }
 
 #endif  // !defined(OS_IOS)
 
 }  // namespace
 
 }  // namespace net