CookieStore: Remove reference counting.

chrome/test/base/testing_profile.cc

Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index defda283ca06aeccd37718eb2f455c5c2daaf49a..f46b85c92baaa79643986dfe7148f41ce198fff9 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -83,6 +83,7 @@
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/common/constants.h"
+#include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_test_util.h"
@@ -159,9 +160,12 @@ class TestExtensionURLRequestContext : public net::URLRequestContext {
   TestExtensionURLRequestContext() {
     content::CookieStoreConfig cookie_config;
     cookie_config.cookieable_schemes.push_back(extensions::kExtensionScheme);
-    set_cookie_store(content::CreateCookieStore(cookie_config));
+    cookie_store_ = content::CreateCookieStore(cookie_config);
+    set_cookie_store(cookie_store_.get());
   }
 
+  scoped_ptr<net::CookieStore> cookie_store_;

[Randy Smith (Not in Mondays), 2016/03/01 20:48:43]

This (anti) pattern of a derived class actually owning the object the base class
has a pointer to does raise a potential failure mode during destruction, because
the derived class is destructed before the base class, so the base class will
have a raw pointer to freed memory.  I presume it's ok ("ok" :-}) since we have
this pattern elsewhere for things other than cookies so presumably the
URLRequestContext destructor can't do anything ugly, but I wanted to raise the
flag that this shift is actually going in the wrong direction for safe
destruction ordering.

[mmenke, 2016/03/01 22:44:45]

True...Though this isn't a "real" URLRequestContext, it's just used as a
URLRequestContextForExtensions, which only uses its CookieStore, and doesn't
make requests.  I want to get rid of the context, at some point.

+
   ~TestExtensionURLRequestContext() override { AssertNoURLRequests(); }
 };