CookieStore: Remove reference counting.

chrome/test/base/testing_profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/testing_profile.h"
 
 #include <utility>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
@@ skipping 65 matching lines @@
 #include "components/webdata_services/web_data_service_wrapper.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/zoom_level_delegate.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/common/constants.h"
+#include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
 #include "chrome/browser/policy/schema_registry_service.h"
 #include "chrome/browser/policy/schema_registry_service_factory.h"
 #include "components/policy/core/common/configuration_policy_provider.h"
 #include "components/policy/core/common/policy_service_impl.h"
@@ skipping 56 matching lines @@
   ~QuittingHistoryDBTask() override {}
 
   DISALLOW_COPY_AND_ASSIGN(QuittingHistoryDBTask);
 };
 
 class TestExtensionURLRequestContext : public net::URLRequestContext {
  public:
   TestExtensionURLRequestContext() {
     content::CookieStoreConfig cookie_config;
     cookie_config.cookieable_schemes.push_back(extensions::kExtensionScheme);
-    set_cookie_store(content::CreateCookieStore(cookie_config));
+    cookie_store_ = content::CreateCookieStore(cookie_config);
+    set_cookie_store(cookie_store_.get());
   }
 
+  scoped_ptr<net::CookieStore> cookie_store_;

[Randy Smith (Not in Mondays), 2016/03/01 20:48:43]

This (anti) pattern of a derived class actually owning the object the base class
has a pointer to does raise a potential failure mode during destruction, because
the derived class is destructed before the base class, so the base class will
have a raw pointer to freed memory.  I presume it's ok ("ok" :-}) since we have
this pattern elsewhere for things other than cookies so presumably the
URLRequestContext destructor can't do anything ugly, but I wanted to raise the
flag that this shift is actually going in the wrong direction for safe
destruction ordering.

[mmenke, 2016/03/01 22:44:45]

True...Though this isn't a "real" URLRequestContext, it's just used as a
URLRequestContextForExtensions, which only uses its CookieStore, and doesn't
make requests.  I want to get rid of the context, at some point.

+
   ~TestExtensionURLRequestContext() override { AssertNoURLRequests(); }
 };
 
 class TestExtensionURLRequestContextGetter
     : public net::URLRequestContextGetter {
  public:
   net::URLRequestContext* GetURLRequestContext() override {
     if (!context_.get())
       context_.reset(new TestExtensionURLRequestContext());
     return context_.get();
@@ skipping 865 matching lines @@
 
   // Note: Owned by |original_profile|.
   return new TestingProfile(path_, delegate_,
 #if defined(ENABLE_EXTENSIONS)
                             extension_policy_,
 #endif
                             std::move(pref_service_), original_profile,
                             guest_session_, supervised_user_id_,
                             std::move(policy_service_), testing_factories_);
 }