Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc

Issue 17010003: Cleanup of system settings constants (ab)use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
index f5bc671675f50ee7c8802c4c2ff88b93dcfaf22c..29957c69dca9eab2b783f5aa56b85516337d7615 100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
@@ -2255,12 +2255,15 @@ bool FileDialogStringsFunction::RunImpl() {
#endif
std::string board;
- const char kMachineInfoBoard[] = "CHROMEOS_RELEASE_BOARD";
chromeos::system::StatisticsProvider* provider =
chromeos::system::StatisticsProvider::GetInstance();
- if (!provider->GetMachineStatistic(kMachineInfoBoard, &board))
+ if (!provider->GetMachineStatistic(
+ chromeos::system::kMachineInfoBoard,
+ &board)) {
board = "unknown";
- dict->SetString(kMachineInfoBoard, board);
+ }
+ dict->SetString(chromeos::system::kMachineInfoBoard,
+ board);
xiyuan 2013/06/18 04:59:23 nit: Does this fit in one line?
zel 2013/06/18 17:56:37 Done.
return true;
}

Powered by Google App Engine
This is Rietveld 408576698