Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issue 1700863002: Add a local generic function into the static generic method tests. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a local generic function into the static generic method tests. Before landing https://codereview.chromium.org/1692993004 we were not able to test this. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/40e0e329fdda0c6cf3d772255bf6ad0b16b75a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-15 20:31:25 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-16 16:55:34 UTC) #2
scheglov
4 years, 10 months ago (2016-02-16 17:49:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40e0e329fdda0c6cf3d772255bf6ad0b16b75a46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698