Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1692993004: Fix for type parameters of a local generic function in a static generic method of a generic class. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for type parameters of a local generic function in a static generic method of a generic class. R=brianwilkerson@google.com, jmesserly@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8ecdb19fb2b5dd4d87fa0a3575783bef6b99b6dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +38 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-13 06:31:44 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-13 16:00:47 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 8ecdb19fb2b5dd4d87fa0a3575783bef6b99b6dd (presubmit successful).
4 years, 10 months ago (2016-02-15 20:08:34 UTC) #4
Jennifer Messerly
4 years, 10 months ago (2016-02-16 17:20:02 UTC) #5
Message was sent while issue was closed.
LGTM. Sneaky one.

Powered by Google App Engine
This is Rietveld 408576698