Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1700833003: Consider focusability even when tabs-to-links is enabled for <svg:a> (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider focusability even when tabs-to-links is enabled for <svg:a> SVGAElement::isKeyboardFocusable could end up returning 'true' even when the element wasn't focusable (because it had "display: none" and hence no LayoutObject) because the value of the 'tabsToLinks' setting would be returned without further checks. Because it wasn't focusable setFocusedElement would not do anything, and focus would remain where it was previously. Make sure the focusable check is considered in this case. This makes the SVGAElement version of this code look the same as the HTMLAnchorElement version. BUG=586200 Committed: https://crrev.com/ad66827206bf24e41a4afa7dd7c3083157506c6c Cr-Commit-Position: refs/heads/master@{#375713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
4 years, 10 months ago (2016-02-15 17:20:05 UTC) #2
pdr.
LGTM!
4 years, 10 months ago (2016-02-16 22:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700833003/1
4 years, 10 months ago (2016-02-16 22:34:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 23:59:53 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 00:01:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad66827206bf24e41a4afa7dd7c3083157506c6c
Cr-Commit-Position: refs/heads/master@{#375713}

Powered by Google App Engine
This is Rietveld 408576698