Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAElement.cpp

Issue 1700833003: Consider focusability even when tabs-to-links is enabled for <svg:a> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAElement.cpp b/third_party/WebKit/Source/core/svg/SVGAElement.cpp
index 88c9a27fc180f21e2da2a2ab525e7378f02acbed..f135ecc04cf5ace35b62fd171ee6322741da161c 100644
--- a/third_party/WebKit/Source/core/svg/SVGAElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAElement.cpp
@@ -198,9 +198,8 @@ bool SVGAElement::isKeyboardFocusable() const
{
if (isFocusable() && Element::supportsFocus())
return SVGElement::isKeyboardFocusable();
-
- if (isLink())
- return document().frameHost()->chromeClient().tabsToLinks();
+ if (isLink() && !document().frameHost()->chromeClient().tabsToLinks())
+ return false;
return SVGElement::isKeyboardFocusable();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/display-none-a-does-not-stop-focus-navigation.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698